what is wrong with this script??

[Martin_SBT]

Guys

I am rewriting all the actions of an AMS4 proj that i decided to bring to the great AMS5. Now, as everybody else, i found out that i need to learn from scratch, since the scripting engine has changed (Dear IR friends, i am sure you could build an action converter for this!!!... Please consider....) Anyway. Here is a script that check if a registry key exist and if not it create folders. It doesnt work at all so if anyone can tell me what is wrong with that, i will be an happy man .

SCDExist = Registry.DoesKeyExist(HKEY_LOCAL_MACHINE, "Software\DAZTools");

--
if SCDExist == "FALSE" then
--Dialog.Message(Copying files, "The \"DAZTools\" needs to copy some files on the Hard drive in order for the utilities to work. (required!). The files are less than 2mb and will be copied to: SCDPath\r\n\r\nPress OK when ready!", MB_OK, MB_ICONEXCLAMATION, MB_DEFBUTTON1)
--
--
--Creating folders
--
Folder.Create("SCDPath\Bin");
Folder.Create("SCDPath\Temp");
--
--
Registry.CreateKey(HKEY_LOCAL_MACHINE, "Software\DAZTools");
Registry.SetValue(HKEY_LOCAL_MACHINE, "Software\DAZTools", "SCDRoot", "C:\DAZTools", REG_SZ);
end



Note: even when i create all my action using the action wizard, i am getting script errors when i preview my project.....


thanks

Martin

[Worm]

True and False don't have to be in Quotes anymore, but they do need to be in lower case. Also remember to double up on the backslash in file paths etc...

SCDExist = Registry.DoesKeyExist(HKEY_LOCAL_MACHINE, "Software\DAZTools"); 

-- 
if not SCDExist then 
--Dialog.Message(Copying files, "The \"DAZTools\" needs to copy some files on the Hard drive in order for the utilities to work. (required!). The files are less than 2mb and will be copied to: SCDPath\r\n\r\nPress OK when ready!", MB_OK, MB_ICONEXCLAMATION, MB_DEFBUTTON1) 
-- 
-- 
--Creating folders 
-- 
Folder.Create(_SourceFolder.."\\SCDPath\\Bin"); 
Folder.Create(_SourceFolder.."\\SCDPath\\Temp"); 
-- 
-- 
Registry.CreateKey(HKEY_LOCAL_MACHINE, "Software\\DAZTools"); 
Registry.SetValue(HKEY_LOCAL_MACHINE, "Software\\DAZTools", "SCDRoot", "C:\\DAZTools", REG_SZ); 
end

[Worm]

After reading through the code again, I think you have the path to your app stored in a variable named SCDPath

If that's true, change the Folder.Create lines to this:

Folder.Create(SCDPath.."\\Bin");
Folder.Create(SCDPath.."\\Temp");

[Martin_SBT]

Thanks Worm

I hope i will get into the new script engine and become familiar with all the details and gotchas very soon!


You've been a great help as usual


Martin

[Stefan_M]

in this case I think you also have to use double-backslash

SCDExist = Registry.DoesKeyExist(HKEY_LOCAL_MACHINE, "Software\DAZTools");

SCDExist = Registry.DoesKeyExist(HKEY_LOCAL_MACHINE, "Software\\DAZTools");



See Online-help:
Scripting guide
-- Variables
-----Variable Scope
--------Local Variables
-----------String

Stefan

[Martin_SBT]

Yeah, thanks dude i found it after Worm's reply!